update hack/tools, update golangci-lint and fix lints #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
force-pushed
the
more-update
branch
9 times, most recently
from
c93bea5
to
b0a5905
Compare
cpanato
changed the title
|
cc @richardcase I'm Working to fix the lints. I might ignore some for now to not have a super huge PR; is that ok? |
Sounds like a plan. We can circle back to them in the future. |
Signed-off-by: cpanato <[email protected]>
cpanato
force-pushed
the
more-update
branch
7 times, most recently
from
887b1cb
to
e0909e8
Compare
Signed-off-by: cpanato <[email protected]>
richardcase
approved these changes
Jul 10, 2024
|
Thanks for this @cpanato, the time and effort is very much appreciated 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: